[Bug 557390] Review Request: ghc-stm - Haskell Software Transactional Memory library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557390

Rakesh Pandit <rpandit at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Rakesh Pandit <rpandit at redhat.com> 2010-01-24 05:55:12 EST ---
[+] Build - http://koji.fedoraproject.org/koji/taskinfo?taskID=1941080  - fine
[+] source ok
from srpm (sha1sum)

[rakesh at dhcp1-96 SPECS]$ sha1sum stm-2.1.1.2.tar.gz 
f0b8264a0fa3a04163ccda0c7250a8c87edcf06e  stm-2.1.1.2.tar.gz
[rakesh at dhcp1-96 SPECS]$ sha1sum ../SOURCES/stm-2.1.1.2.tar.gz 
f0b8264a0fa3a04163ccda0c7250a8c87edcf06e  ../SOURCES/stm-2.1.1.2.tar.gz

[+] name fine
[+] URL fine
[+] rpmlint - ok 

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/SRPMS/ghc-stm-2.1.1.2-2.fc13.src.rpm
ghc-stm.src: W: spelling-error-in-summary en_US Haskell
ghc-stm.src: W: spelling-error-in-summary en_US Transactional
ghc-stm.src: W: spelling-error-in-description en_US composable
ghc-stm.src: W: spelling-error-in-description en_US Haskell
ghc-stm.src: W: strange-permission stm-2.1.1.2.tar.gz 0600L
ghc-stm.src: W: no-cleaning-of-buildroot %install
ghc-stm.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 7 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-stm-2.1.1.2-2.fc13.i686.rpm
ghc-stm.i686: W: spelling-error-in-summary en_US Haskell
ghc-stm.i686: W: spelling-error-in-summary en_US Transactional
ghc-stm.i686: W: spelling-error-in-description en_US composable
ghc-stm.i686: W: spelling-error-in-description en_US Haskell
ghc-stm.i686: W: unstripped-binary-or-object
/usr/lib/ghc-6.12.1/stm-2.1.1.2/libHSstm-2.1.1.2-ghc6.12.1.so
ghc-stm.i686: W: executable-stack
/usr/lib/ghc-6.12.1/stm-2.1.1.2/libHSstm-2.1.1.2-ghc6.12.1.so
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-stm-devel-2.1.1.2-2.fc13.i686.rpm
ghc-stm-devel.i686: W: spelling-error-in-summary en_US Haskell
ghc-stm-devel.i686: W: spelling-error-in-summary en_US Transactional
ghc-stm-devel.i686: W: spelling-error-in-description en_US composable
ghc-stm-devel.i686: W: spelling-error-in-description en_US Haskell
ghc-stm-devel.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-stm-doc-2.1.1.2-2.fc13.i686.rpm
ghc-stm-doc.i686: W: spelling-error-in-summary en_US Haskell
ghc-stm-doc.i686: W: spelling-error-in-summary en_US Transactional
ghc-stm-doc.i686: W: spelling-error-in-description en_US composable
ghc-stm-doc.i686: W: spelling-error-in-description en_US Haskell
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-stm-prof-2.1.1.2-2.fc13.i686.rpm
ghc-stm-prof.i686: E: devel-dependency ghc-stm-devel
ghc-stm-prof.i686: W: spelling-error-in-summary en_US Haskell
ghc-stm-prof.i686: W: spelling-error-in-summary en_US Transactional
ghc-stm-prof.i686: W: spelling-error-in-description en_US composable
ghc-stm-prof.i686: W: spelling-error-in-description en_US Haskell
ghc-stm-prof.i686: W: no-documentation
ghc-stm-prof.i686: W: devel-file-in-non-devel-package
/usr/lib/ghc-6.12.1/stm-2.1.1.2/libHSstm-2.1.1.2_p.a
1 packages and 0 specfiles checked; 1 errors, 6 warnings.

Ignored.

[+] spec name fine
[+] license ok (copy present) and source has marking
[+] source tree ok (no binaries present)
[+] archs - fine
[+] spec file legible and in american english
[+] BR's ok
[+] %files ok
[+] folders owned - ok

main
/usr/lib/ghc-6.12.1/stm-2.1.1.2
/usr/share/doc/ghc-stm-2.1.1.2
devel
/usr/lib/ghc-6.12.1/stm-2.1.1.2
/usr/lib/ghc-6.12.1/stm-2.1.1.2/Control
/usr/lib/ghc-6.12.1/stm-2.1.1.2/Control/Concurrent
/usr/lib/ghc-6.12.1/stm-2.1.1.2/Control/Monad
/usr/lib/ghc-6.12.1/stm-2.1.1.2/Control/Sequential
doc
/usr/share/doc/ghc/html/libraries/stm-2.1.1.2

[+] source builds fine on fedora ghc archs
[+] no bundled dependencies
[+] %clean section ok
[+] filenames - ok (valid)
[+] profiling ok
[+] lib goes to %{_libdir}/ghc-%{ghc_version}/%{pkg_name}-%{version}
[+] new macros

APPROVED

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.