[Bug 557392] Review Request: ghc-parallel - Haskell parallel programming library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557392

Rakesh Pandit <rpandit at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Rakesh Pandit <rpandit at redhat.com> 2010-01-24 06:30:18 EST ---
[+] Build - http://koji.fedoraproject.org/koji/taskinfo?taskID=1941092  - fine
[+] source ok
from srpm (sha1sum)

[rakesh at dhcp1-96 SPECS]$ sha1sum parallel-1.1.0.1.tar.gz 
39bcd5c8a896914c7ddc853049005a71a4eaabb6  parallel-1.1.0.1.tar.gz
[rakesh at dhcp1-96 SPECS]$ sha1sum ../SOURCES/parallel-1.1.0.1.tar.gz 
39bcd5c8a896914c7ddc853049005a71a4eaabb6  ../SOURCES/parallel-1.1.0.1.tar.gz

[+] name fine
[+] URL fine
[+] rpmlint - ok 

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/SRPMS/ghc-parallel-1.1.0.1-2.fc13.src.rpm
ghc-parallel.src: W: spelling-error-in-summary en_US Haskell
ghc-parallel.src: W: spelling-error-in-description en_US Haskell
ghc-parallel.src: W: no-cleaning-of-buildroot %install
ghc-parallel.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-parallel-1.1.0.1-2.fc13.i686.rpm
ghc-parallel.i686: W: spelling-error-in-summary en_US Haskell
ghc-parallel.i686: W: spelling-error-in-description en_US Haskell
ghc-parallel.i686: W: unstripped-binary-or-object
/usr/lib/ghc-6.12.1/parallel-1.1.0.1/libHSparallel-1.1.0.1-ghc6.12.1.so
ghc-parallel.i686: W: executable-stack
/usr/lib/ghc-6.12.1/parallel-1.1.0.1/libHSparallel-1.1.0.1-ghc6.12.1.so
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-parallel-devel-1.1.0.1-2.fc13.i686.rpm
ghc-parallel-devel.i686: W: spelling-error-in-summary en_US Haskell
ghc-parallel-devel.i686: W: spelling-error-in-description en_US Haskell
ghc-parallel-devel.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-parallel-doc-1.1.0.1-2.fc13.i686.rpm
ghc-parallel-doc.i686: W: spelling-error-in-summary en_US Haskell
ghc-parallel-doc.i686: W: spelling-error-in-description en_US Haskell
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Ignored.

[rakesh at dhcp1-96 SPECS]$ rpmlint
/home/rakesh/rpmbuild/RPMS/i686/ghc-parallel-prof-1.1.0.1-2.fc13.i686.rpm
ghc-parallel-prof.i686: E: devel-dependency ghc-parallel-devel
ghc-parallel-prof.i686: W: spelling-error-in-summary en_US Haskell
ghc-parallel-prof.i686: W: spelling-error-in-description en_US Haskell
ghc-parallel-prof.i686: W: no-documentation
ghc-parallel-prof.i686: W: devel-file-in-non-devel-package
/usr/lib/ghc-6.12.1/parallel-1.1.0.1/libHSparallel-1.1.0.1_p.a
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

Ignored.
[+] spec name fine
[+] license ok (copy present) and source has marking
[+] source tree ok (no binaries present)
[+] archs - fine
[+] spec file legible and in american english
[+] BR's ok
[+] %files ok
[+] folders owned - ok

main
/usr/lib/ghc-6.12.1/parallel-1.1.0.1
/usr/share/doc/ghc-parallel-1.1.0.1
devel
/usr/lib/ghc-6.12.1/parallel-1.1.0.1
/usr/lib/ghc-6.12.1/parallel-1.1.0.1/Control
doc
/usr/share/doc/ghc/html/libraries/parallel-1.1.0.1

[+] source builds fine on fedora ghc archs
[+] no bundled dependencies
[+] %clean section ok
[+] filenames - ok (valid)
[+] profiling ok
[+] lib goes to %{_libdir}/ghc-%{ghc_version}/%{pkg_name}-%{version}
[+] new macros

APPROVED

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.