[Bug 557393] Review Request: ghc-haskell-src - Haskell source-code manipulation library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557393

Rakesh Pandit <rpandit at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Rakesh Pandit <rpandit at redhat.com> 2010-01-24 06:43:27 EST ---
[+] Build - http://koji.fedoraproject.org/koji/taskinfo?taskID=1941095  - fine
[+] source ok
from srpm (sha1sum)

[rakesh at dhcp1-96 SPECS]$ sha1sum haskell-src-1.0.1.3.tar.gz 
21b14d8b885e9a2ca6b4226d7619b7ca966097fe  haskell-src-1.0.1.3.tar.gz
[rakesh at dhcp1-96 SPECS]$ sha1sum ../SOURCES/haskell-src-1.0.1.3.tar.gz 
21b14d8b885e9a2ca6b4226d7619b7ca966097fe  ../SOURCES/haskell-src-1.0.1.3.tar.gz

[+] name fine
[+] URL fine
[+] rpmlint - ok 

===========================================================================
Koji build rpm
/tmp/gachvByqpk/kojiy20BeW/1941097/ghc-haskell-src-prof-1.0.1.3-3.fc13.i686.rpm
output:
===========================================================================

Rpmlint Messages:
ghc-haskell-src-prof.i686: E: devel-dependency ghc-haskell-src-devel
ghc-haskell-src-prof.i686: W: no-documentation
ghc-haskell-src-prof.i686: W: devel-file-in-non-devel-package
/usr/lib/ghc-6.12.1/haskell-src-1.0.1.3/libHShaskell-src-1.0.1.3_p.a
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

Ignored.

===========================================================================
Koji build rpm
/tmp/gachvByqpk/kojiy20BeW/1941097/ghc-haskell-src-doc-1.0.1.3-3.fc13.i686.rpm
output:
===========================================================================

Rpmlint Messages:
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Clean.

===========================================================================
Koji build rpm
/tmp/gachvByqpk/kojiy20BeW/1941097/ghc-haskell-src-1.0.1.3-3.fc13.i686.rpm
output:
===========================================================================

Rpmlint Messages:
ghc-haskell-src.i686: W: unstripped-binary-or-object
/usr/lib/ghc-6.12.1/haskell-src-1.0.1.3/libHShaskell-src-1.0.1.3-ghc6.12.1.so
ghc-haskell-src.i686: W: executable-stack
/usr/lib/ghc-6.12.1/haskell-src-1.0.1.3/libHShaskell-src-1.0.1.3-ghc6.12.1.so
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Ignored.

===========================================================================
Koji build rpm
/tmp/gachvByqpk/kojiy20BeW/1941097/ghc-haskell-src-devel-1.0.1.3-3.fc13.i686.rpm
output:
===========================================================================

Rpmlint Messages:
ghc-haskell-src-devel.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Ignored.

===========================================================================
Log info /tmp/gachvByqpk/kojiy20BeW/1941096/build.log:
===========================================================================
Log warnings:warning: Could not canonicalize hostname:
xb-01.phx2.fedoraproject.org
Log warnings:    Warning: Module `Prelude' is deprecated:
----------------------------------------------------------------------------

Log warnings:    Warning: Bindings containing unlifted types must use an
outermost bang pattern:
----------------------------------------------------------------------------

Ignored.

===========================================================================
Log info /tmp/gachvByqpk/kojiy20BeW/1941097/build.log:
===========================================================================
Log warnings:warning: Could not canonicalize hostname:
xb-01.phx2.fedoraproject.org
Log warnings:    Warning: Module `Prelude' is deprecated:
----------------------------------------------------------------------------

Log warnings:    Warning: Bindings containing unlifted types must use an
outermost bang pattern:
----------------------------------------------------------------------------

Log warnings:Warning: The documentation for the following packages are not
installed. No
Log warnings:warning: Could not canonicalize hostname:
xb-01.phx2.fedoraproject.org
===========================================================================
Log check ends:
===========================================================================

Ignored.

May you check with bindings contain unlifted types warnings in log ? They don't
seem to be harmful, but still have a look.

[+] spec name fine
[+] license ok (copy present) and source has marking
[+] source tree ok (no binaries present)
[+] archs - fine
[+] spec file legible and in american english
[+] BR's ok
[+] %files ok
[+] folders owned - ok

main
/usr/lib/ghc-6.12.1/haskell-src-1.0.1.3
/usr/share/doc/ghc-haskell-src-1.0.1.3
devel
/usr/lib/ghc-6.12.1/haskell-src-1.0.1.3
/usr/lib/ghc-6.12.1/haskell-src-1.0.1.3/Language
/usr/lib/ghc-6.12.1/haskell-src-1.0.1.3/Language/Haskell
doc
/usr/share/doc/ghc/html/libraries/haskell-src-1.0.1.3

[+] source builds fine on fedora ghc archs
[+] no bundled dependencies
[+] %clean section ok
[+] filenames - ok (valid)
[+] profiling ok
[+] lib goes to %{_libdir}/ghc-%{ghc_version}/%{pkg_name}-%{version}
[+] new macros

APPROVED

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.