[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508750

--- Comment #9 from Christoph Wickert <cwickert at fedoraproject.org> 2010-01-25 10:42:29 EST ---
(In reply to comment #7)

> You could simplify the spec file a little by changing %files to just include:
> %{python_sitelib}/*
> That would collapse 2 %files entries to one, and then you wouldn't need the
> "pyver" macro at all.

This is a bad idea because the build will no longer fail if the egg fails to
build. The %{pyver} macro can be dropped nevertheless by simply changing this
line to 
%{python_sitelib}/trash_cli-*.egg-info
or similar.

> The license looks correct.  The included PKG-INFO and setup.py
> files say that the liecnse is "GPL v2", and the included file COPYING
> is the text of GPL v2.

By only looking at the COPYING or the egg you cannot really desinguish beteween
"GPLv2 only" or "GPLv2 or any later version". You need to look at the headers
of the source code and they clearly say it's GPLv2+

> I recommend that this package install a /usr/bin/trash, and that "man trash"
> also works.  You can make /usr/bin/trash a symlink to trash-put, if you'd like.
>  That way, the docs are right, *AND* it makes it easy for people to invoke
> (just replace "rm" with "trash").    

On the one hand you are right on the other it contradicts
http://fedoraproject.org/wiki/Packaging:Conflicts#Potential_Conflicting_Files
and https://fedoraproject.org/wiki/Packaging_tricks#Use_of_common_namespace

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.