[Bug 557794] Review Request: ykpers - Yubikey personalization tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557794

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-25 13:02:36 EST ---
Some notes:

* SourceURL
  - It is recommended to use %{name}, %{version} (especially
    %{version}) in source URL because with this you won't probably
    have to modify sourceURL when version is upgraded.
    https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* pkgconfig
  - "Requires: pkgconfig" on -devel subpackage is no longer needed
    (on Fedora) because current rpmbuild will automatically add this
    dependency when pkgconfig .pc file is found.

* Timestamps
  - Like bug 557776, please consider to add 'INSTALL="install -p'
    to "make install".

* Documents
  - "INSTALL" file is usually for people trying to build the software
    by themselves and is not needed for people trying to install it
    using rpm.

* Directory ownership issue
  https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
  - The directory "%{_includedir}/ykpers-1/" itself is not owned
    by any packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.