[Bug 551878] Review Request: font-manager - A font management application for the GNOME desktop environment

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 25 21:35:16 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551878

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #15 from Michael Schwendt <mschwendt at gmail.com> 2010-01-25 16:35:12 EST ---
* That does it!

* Relocating the temp dir into a private directory below $HOME is not ideal
(with regard to environments where TMP is faster), but more secure than the
prev.release.

* libxml2-python : yes, a false positive

* Empty %doc files : not really worth the increased effort to deal with them.
Though, note that it _would_ be possible to examine the extracted source
tarball in %prep and place guards after %setup. E.g. terminate the build if
special conditions are met or not. Not specific to empty %doc files, can be
helpful with optional source directories and other conditions, too.


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list