[Bug 557169] Review Request: bristol - Synthesizer emulator

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 25 23:18:14 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557169

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #14 from Thomas Spura <tomspur at fedoraproject.org> 2010-01-25 18:18:09 EST ---
(In reply to comment #11)
> WRT the INSTALL.

Can be removed before the import.

> WRT zero-length files, they may not always be zero-length, and I see no harm in
> including them.  

That's why I said 'check, if the zero-length files are needed for runtime' ;)

They are plainly 'seeable' and are not hidden files, so I consider this as a
SHOULD, but not as a blocker.

###########################################

With the removed INSTALL, this is approved.

###########################################


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list