[Bug 469931] Review Request: ipmiutil - IPMI Management Utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469931

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|BuildFails                  |

--- Comment #18 from Jason Tibbitts <tibbs at math.uh.edu> 2010-01-25 18:49:40 EST ---
This is still marked as not building; you seem to have posted a new package but
not cleared the whiteboard.  If you're wondering why nobody's commented on your
ticket, that certainly contributes (as it won't appear in the review queue). 
I've cleared that for you.

You may still want to address the existing rpmlint complaints:

  ipmiutil.x86_64: W: incoherent-version-in-changelog
   2.5.1 ['2.5.1-1', '2.5.1-1']
Your changelog entry isn't in the proper format (missing the package release)

  ipmiutil.x86_64: W: dangerous-command-in-%post cp
  ipmiutil.x86_64: W: dangerous-command-in-%postun rm
You should justify these.

  ipmiutil.x86_64: E: use-tmp-in-%post    
You should verify that any usage of /tmp or /var/tmp in your scriptlets is
secure.

  ipmiutil.x86_64: W: service-default-enabled /etc/rc.d/init.d/ipmiutil_asy
  ipmiutil.x86_64: W: service-default-enabled /etc/rc.d/init.d/ipmiutil_wdt
Don't enable services by default.

  ipmiutil.x86_64: W: no-reload-entry /etc/rc.d/init.d/ipmiutil_asy
  ipmiutil.x86_64: W: no-reload-entry /etc/rc.d/init.d/ipmiutil_wdt
Service scripts should have the usual set of targets.

  ipmiutil.x86_64: E: subsys-not-used /etc/rc.d/init.d/ipmiutil_asy
  ipmiutil.x86_64: E: subsys-not-used /etc/rc.d/init.d/ipmiutil_wdt
No use of /var/lock/subsys for proper lockfiles.

  ipmiutil.x86_64: W: service-default-enabled /etc/rc.d/init.d/ipmi_port
  ipmiutil.x86_64: W: missing-lsb-keyword Required-Stop in
/etc/rc.d/init.d/ipmi_port
  ipmiutil.x86_64: W: missing-lsb-keyword Short-Description in
/etc/rc.d/init.d/ipmi_port
  ipmiutil.x86_64: W: service-default-enabled /etc/rc.d/init.d/ipmi_port
  ipmiutil.x86_64: E: no-status-entry /etc/rc.d/init.d/ipmi_port
  ipmiutil.x86_64: W: no-reload-entry /etc/rc.d/init.d/ipmi_port
  ipmiutil.x86_64: E: subsys-not-used /etc/rc.d/init.d/ipmi_port
In the same basic vein as the above.

  ipmiutil-debuginfo.x86_64: E: empty-debuginfo-package
Debuginfo generation is broken.  Verify that the proper compiler flags are used
(-g) and that nothing strips the binaries.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.