[Bug 226098] Merge Review: linuxdoc-tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226098

--- Comment #2 from Kamil Dudka <kdudka at redhat.com> 2010-01-26 10:03:10 EST ---
considered OK
=============
- almost silent rpmlint (only one spelling false alarm)
- sane summary/description
- valid project URL and source URL
- upstream tarball is the same as the one from look-aside cache
- md5 hash matches the sources
- dist tag OK
- license tag OK
- BuildRoot tag OK
- %build OK
- %clean OK
- %defattr OK

may be better
=============
- remove a redundant configure option --with-installed-nsgmls

- file doc/copyright is copy-pasted from iso-entities/COPYING, moreover the
file is not used either

- it would be good to package also COPYING from the root of the tarball and all
the referred documents from there:
    * sgmls-1.1/LICENSE
    * iso-entities/COPYING
    * entity-map/COPYING

- %post/%postun: the ambiguously looking chain of && and || may be replaced by
an if/then/fi construction (and perhaps also decorated by a commented)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.