[Bug 225703] Merge Review: docbook-style-dsssl
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jan 26 15:40:41 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225703
--- Comment #2 from Kamil Dudka <kdudka at redhat.com> 2010-01-26 10:40:38 EST ---
considered OK
=============
- almost silent rpmlint (only some spelling false alarms)
- sane summary/description
- valid project URL and source URL
- upstream tarball is the same as the one from look-aside cache
- md5 hash matches the sources
- dist tag OK
- license tag OK
- %install OK
- %clean OK
- %files OK
- %defattr OK
- %doc OK
may be better
=============
- BuildRoot tag should be %(mktemp -ud
%{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
- explicit Requires are not commented as they should be
- missing post/preun dependency on sgml-common
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the package-review
mailing list