[Bug 558824] Review Request: rubygem-xmpp4r - XMPP4R is an XMPP/Jabber library for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=558824

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-26 13:18:01 EST ---
Some notes

* %define -> %global
  - Now we prefer to use %global instead of %define
   
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

* Unneeded macros
  - The defined %ruby_sitelib seems to be used nowhere.

* Testing
  - As this package contains test/ directory, please add %check stage
    and execute some test program (like $ rake test ).

* Directory ownership issue
  https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
  - The directories themselves are not owned by any packages.
-------------------------------------------------------------------
/usr/lib/ruby/gems/1.8/gems/xmpp4r-0.5/data
/usr/lib/ruby/gems/1.8/gems/xmpp4r-0.5/data/doc
/usr/lib/ruby/gems/1.8/gems/xmpp4r-0.5/data/doc/xmpp4r
-------------------------------------------------------------------

* %doc specification
  - I don't see the necessity to use %doc in -doc subpackage as
    its name already shows that this (-doc) subpackage is for
    documentation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.