[Bug 554464] Review Request: python-pebl - Python Environment for Bayesian Learning

bugzilla at redhat.com bugzilla at redhat.com
Tue Jan 26 22:24:52 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=554464

--- Comment #2 from Tadej Janež <tadej.janez at tadej.hicsalta.si> 2010-01-26 17:24:48 EST ---
First of all, thank you for reviewing my package!

(In reply to comment #1)
> Review:
> Needswork:
> - Requires: python
>   This is added automatically, please delete that.
> - There is no python-setuptools-devel any more, please use python-setuptools.
> - Please be a bit more explicit in %files to notice, when the egg can't be
> build:
>   e.g.:
>   %{python_sitearch}/pebl/
>   %{python_sitearch}/pebl-*.egg-info

Ok, I fixed those.

> - %check is missing:
>   %{__python} setup.py test
> 
> This is currently failing. Maybe you can talk to upstream about this too.

I asked the upstream author about the test failures and I'm waiting his reply.

> - shipping the testsuite doesn't make sense, please delete that.
>   (Maybe %exclude %{python_sitearch}/pebl/test* in %files)

Why do other Python packages include it? For example: numpy, scipy,
python-boto, ...

What should I do with _network.c and _cpd.c, which give me rpmlint errors:
python-pebl.i586: W: devel-file-in-non-devel-package
/usr/lib/python2.6/site-packages/pebl/_network.c
python-pebl.i586: W: devel-file-in-non-devel-package
/usr/lib/python2.6/site-packages/pebl/_cpd.c

> - Missing Requires: numpy, pydot, boto, matplotlib
>   What is ipython1.kernel.api? (file src/pebl/taskcontroller/ec2ipy1.py)
>   (I hope that's it, please double check.)

Yes, I checked and added the following Requires:
Requires: numpy
Requires: pydot
# The Requires below are optional, needed for certain types of functionality
# Requires for creating HTML reports of Pebl results
Requires: python-matplotlib
Requires: graphviz
Requires: python-simplejson
# Requires for the Amazon EC2 Task Controller
Requires: python-boto

The ipython1.kernel.api is part of IPython1 and is used for the IPython1 Task
Controller. IPython1 is the next version of the popular IPython shell that also
includes an interactive, clustering solution. Pebl can use IPython1 to execute
learners in parallel.

However, IPython1 has ceased since then and the parallel processing has been
included in IPython >= 0.9.

The last missing Requires is PyXg, which is the python package for the Apple
XGrid Task Controller.

Neither of IPython1 and PyXg are included in Fedora, however, they are not
necessary for running the program. Should I make a README.package file
describing the situation or should I mention this in the summary of the
package. What do you think?

Lastly, rpmlint gives me the following error:
python-pebl.i586: E: explicit-lib-dependency python-matplotlib
What does that mean?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list