[Bug 551911] Review Request: monodevelop-boo - A boo plugin for monodevelop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551911

--- Comment #3 from Christian Krause <chkr at plauener.de> 2010-01-26 18:08:12 EST ---
Hello Paul,

thanks for the new package - here is the complete review:

I have tested the following src.rpm:
http://www.all-the-johnsons.co.uk/fedora/monodevelop-boo-2.2-2.fc13.src.rpm


* rpmlint: TODO
rpmlint RPMS/i686/monodevelop-boo-* SRPMS/monodevelop-boo-2.2-2.fc13.src.rpm
SPECS/monodevelop-boo.spec
monodevelop-boo.i686: W: spelling-error-in-summary en_US Addin
monodevelop-boo.i686: W: spelling-error-in-description en_US Addin
monodevelop-boo.i686: E: no-binary
monodevelop-boo.i686: W: only-non-binary-in-usr-lib
monodevelop-boo.i686: W: no-documentation
monodevelop-boo-devel.i686: W: spelling-error-in-summary en_US Addin
monodevelop-boo-devel.i686: W: spelling-error-in-description en_US Addin
monodevelop-boo-devel.i686: W: no-documentation
monodevelop-boo.src: W: spelling-error-in-summary en_US Addin
monodevelop-boo.src: W: spelling-error-in-description en_US Addin
monodevelop-boo.src:42: W: configure-without-libdir-spec
monodevelop-boo.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line
4)
SPECS/monodevelop-boo.spec:42: W: configure-without-libdir-spec
SPECS/monodevelop-boo.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 5,
tab: line 4)
3 packages and 1 specfiles checked; 1 errors, 13 warnings.

- no-binary, no-documentation and only-non-binary-in-usr-lib are false
positives
- mixed-use-of-spaces-and-tabs should be fixed
- spelling errors: IMHO "Addin" should be written "Add-in" (as it is done in
monodevelop as well as on its web page)
- configure-without-libdir-spec is also a false positive, since the packages
contains a custom-made configure script which doesn't need or handle
the --libdir parameter

* naming: OK
- name matches upstream
- spec file name matches package name

* sources: OK
- md5sum: 25abd742dc4a0ffcf17c537dea6d791f  monodevelop-boo-2.2.tar.bz2
- sources matches upstream
- Source0 tag ok
- spectool -g  works

* binaries in upstream sources: OK (n/a)

* License: OK
- License in spec file does match the actual license
- GPLv2+ license acceptable for Fedora

* package containing *.pc files must "Requires: pkgconfig": OK

* spec file written in English and legible: minor TODOs
- please split the very long line of the BuildRequires so that it fit into
80 characters for better readability
- please append a "/" to the URL to get a 100% correct URL ;-)

* compilation: TODO (minor)
- please check whether the package does support a parallel build, if not please
add a short comment in the %build section
- builds fine in koji: F13

* BuildRequires: OK

* locales handling: OK

* ldconfig in %post and %postun: OK (n/a)

* package owns all directories that it creates: OK

* %files section: TODO
Please delete the empty locale directory in the %install section:
/usr/lib/monodevelop/AddIns/BooBinding/locale

* no files listed twice in %files: OK

* file permissions: OK
- %defattr used
- actual permissions in packages ok

* %clean section: OK

* macro usage: OK

* code vs. content: OK

* main package should not contain development related parts: OK

* large documentation into subpackage: OK (n/a)

* header files in -devel subpackage: OK (n/a)

* static libraries in -static package: OK (n/a)

* *.so link in -devel package: OK (n/a)

* devel package requires base package using fully versioned dependency: OK

* packages must not contain *.la files: OK

* GUI applications must provide *.desktop file: OK (n/a)

* packages must not own files/dirs already owned by other packages: OK

* rm -rf $RPM_BUILD_ROOT at the beginning of %install: OK

* all filenames UTF-8: OK

* functional test: TODO
- unfortunately moving the locale data into /usr/share/locale makes monodevelop
not recognize them anymore:
- start monodevelop with "LANG=de_DE monodevelop"
- open a new project with "Datei->Neu->Projektmappe"
- select Boo and click onto the Gtk# Project
- the help text below is still "Creates a Boo/Gtk# project"
- if the locales data would be still at the old place then this text would
be "Erzeugt ein Boo/Gtk# Projekt"
- there may be two fixes:
a) leave the locale where they were put by "make install", but note that they
still have to be packaged correctly using %lang(xx) macros
b) make the boo addin/monodevelop aware of the new location

* debuginfo sub-package: OK (n/a)

Best regards,
Christian

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.