[Bug 226352] Merge Review: quagga

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226352

Jiri Skala <jskala at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jskala at redhat.com

--- Comment #4 from Jiri Skala <jskala at redhat.com> 2010-01-27 03:43:34 EST ---
I've modified spec file to be Packaging Guideline compliant and rpmlint a bit
more silent. There is explanation to rest of E & W of rpmlint:

quagga.x86_64: W: conffile-without-noreplace-flag
/etc/quagga/ospf6d.conf.sample
quagga.x86_64: W: conffile-without-noreplace-flag /etc/quagga/vtysh.conf.sample
quagga.x86_64: W: conffile-without-noreplace-flag
/etc/quagga/ripngd.conf.sample
quagga.x86_64: W: conffile-without-noreplace-flag /etc/quagga/zebra.conf.sample
quagga.x86_64: W: conffile-without-noreplace-flag /etc/quagga/ripd.conf.sample
quagga.x86_64: W: conffile-without-noreplace-flag /etc/quagga/bgpd.conf.sample
quagga.x86_64: W: conffile-without-noreplace-flag /etc/quagga/bgpd.conf.sample2
quagga.x86_64: W: conffile-without-noreplace-flag /etc/quagga/ospfd.conf.sample
COMMENT: This is an intention. These files are sample therefore is not
necessary  (even must not) to use noreplace keyword

quagga.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/quagga/libospfapiclient.so
quagga.x86_64: W: devel-file-in-non-devel-package /usr/lib64/quagga/libzebra.so
quagga.x86_64: W: devel-file-in-non-devel-package /usr/lib64/quagga/libospf.so
COMMENT: THis is used library not devel file

quagga.x86_64: E: non-standard-dir-perm /var/run/quagga 0771
quagga.x86_64: E: non-standard-dir-perm /etc/quagga 0751
quagga.x86_64: E: non-readable /etc/logrotate.d/quagga 0640
quagga.x86_64: E: non-standard-dir-perm /var/log/quagga 0770
COMMENT: 

quagga.x86_64: W: dangerous-command-in-%post chown
COMMENT: intention

quagga.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/zebra
quagga.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/zebra
quagga.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/zebra
quagga.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/ospfd
quagga.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ospfd
quagga.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ospfd
quagga.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/ripd
quagga.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ripd
quagga.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ripd
quagga.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/ospf6d
quagga.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ospf6d
quagga.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ospf6d
quagga.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/ripngd
quagga.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ripngd
quagga.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ripngd
quagga.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/bgpd
quagga.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/bgpd
quagga.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/bgpd
COMMENT: this is an intention don't use these tags.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.