[Bug 523601] Review Request: swish-e - Simple Web Indexing System for Humans - Enhanced

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523601

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?

--- Comment #11 from Parag AN(पराग) <panemade at gmail.com> 2010-01-27 06:07:44 EST ---

koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1947429
Suggestions:-
1) rpmlint is NOT silent for SRPM and for RPM.
perl-SWISH.i686: W: no-documentation
==> You should add README and Changes files too this package.

swish-e.i686: W: shared-lib-calls-exit /usr/lib/libswish-e.so.2.0.0
exit at GLIBC_2.0
==> This should be notified to upstream that avoid using exit() in library
code.

swish-e.src:97: E: hardcoded-library-path in %{_prefix}/lib/swish-e/perl/*
swish-e.src:100: E: hardcoded-library-path in %{_prefix}/lib/swish-e/*cgi
swish-e.src:102: E: hardcoded-library-path in
%{_prefix}/lib/swish-e/swishspider
swish-e.src:103: E: hardcoded-library-path in %{_prefix}/lib/swish-e/*pl
==>  no issues for this.

swish-e-perl.i686: W: no-documentation
==> Here I can see README in prog-bin. Add it.


2) We don't add perl packages as Requires: as rpm/yum supposed to auto detect
dependencies and install them. So add them only if yum fails to auto-detect it.

3) you can move following 
Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
 to
 perl-SWISH package.

For more information on perl packaging, you can look at perl specfile template.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.