[Bug 553850] Review Request: pki-ra - The Dogtag PKI Registration Authority

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553850

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #4 from Parag AN(पराग) <panemade at gmail.com> 2010-01-27 06:34:32 EST ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1947420
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
e2b42b7b72e1fafef558eec86c33c7635f01c2c5  pki-ra-1.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ initscripts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.


I don't see any need to add sub-package pki-ra-perl that will install pki-ra
perl modules as install path for these modules are not standard perl module
installation path.


Suggestions:
1) I even don't see use of "Requires: sqlite" as its providing .so files and I
see no code in pki-ra consuming it.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.