[Bug 529198] Review Request: pynac - manipulation of symbolic expressions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529198

Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |cwickert at fedoraproject.org

--- Comment #7 from Christoph Wickert <cwickert at fedoraproject.org> 2010-01-27 08:26:12 EST ---
Just for completeness and because David asked to become a sponsor recently:

(In reply to comment #6)
> ISSUE.  It has a .pc file, but no "Requires: pkgconfig".    

Strictly speaking this is not needed any longer because rpm nowadays detects
this automatically:

Processing files: pynac-devel-0.1.10-1.fc12.x86_64
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: /usr/bin/pkg-config libpynac-0.1.so.10()(64bit)

However I agree with David that the devel package should require pkgconfig
explicitly.


Please add INSTALL='install -p' to 'make install...' to preserve the original
time stamps of the header files in the devel package. See 
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.