[Bug 509160] Review Request: mine_detector – a mine-finding game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509160

--- Comment #15 from David A. Wheeler <dwheeler at dwheeler.com> 2010-01-27 12:23:24 EST ---
>> Also: Usually files given as Source: have the package name prefixed.
>> That way, simultaneous builds won't cause trouble.
>> I think you should do that; be sure to rename them back to their
>> expected name.

>OK, done.

Not quite; "license.txt" doesn't have a prefix.  If someone simultaneously
built this and another package that ALSO had a "license.txt", using a shared
directory, you could have a race condition where the license.txt of that OTHER
package would be incorporated into the final build for THIS package.  Eeek.

Best to change this to something like mine_detector_license.txt,
then in %prep do:
cp -p %{SOURCE4} license.txt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.