[Bug 559117] Review Request: lcdtest - display test pattern generator

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 27 23:22:48 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=559117

--- Comment #9 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-01-27 18:22:44 EST ---
(In reply to comment #7)
> OK.  Regarding the icon, I'll move it into /usr/share/pixmaps as recommended,
> but I thought I'd point out why I put it in /usr/share/icons/hicolor in the
> first place.  From the freedesktop.org Icon Theme Specification:

Hmm, I'm no expert, but the beginning of the "Directory Layout" section states:

"Icons and themes are looked for in a set of directories. By default, apps
should look in $HOME/.icons (for backwards compatibility), in
$XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order)."

> I can't see any way to interpret this that allows for the hicolor theme to be
> optional; it seems that if Fedora intends to be compliant with freedesktop.org
> standards, the hicolor theme *must* be provided.
> 
> Anyhow, I'm not pushing for any change in Fedora policy, but since Fedora icon
> policy differs from the freedesktop.org standard, it might be desirable to
> update the desktop section of the packaging policy to explicitly state that the
> basic fedora icon requirement is to use /usr/share/pixmaps.  That might prevent
> another novice packager from making the same mistake I did.

OK. If you're interested in packaging standards, you can write up a proposal
for the Fedora Packaging Committee, which can then propose the guideline to the
Fedora Steering Committee.

**

This package is good to go. I won't give it a formal approval yet, since you
wouldn't be able to do anything with it yet since you're not a member of the
packaging group.

Do the one other informal review, and I will sponsor you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list