[Bug 532527] Review request: junit-addons - JUnitX helper classes for JUnit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532527

--- Comment #3 from David A. Wheeler <dwheeler at dwheeler.com> 2010-01-28 17:27:07 EST ---
It seems to meet most of the Java guidelines. Package name == JAR name,
JAR file in %{_javadir}.

So the only Java-specific guidelines issues I see are the ones I already
complained about: the release# (make it JPP number.1), missing
BuildRequires/Requires, and lack of GCJ bits.

The licensing seems okay.
The .spec file claims that the license is ASL 1.1.
The BUILD includes a LICENSE file that is indeed ASL 1.1
(I checked with http://www.apache.org/licenses/LICENSE -- it's the same
text except for template instantiation, e.g., different copyright holder).
I did a spot-check of source code in src, seemed to match:
src/main/junitx/tool/TestClassValidator.java
src/main/junitx/framework/NamingAssert.java
Some source files had no license, but given that they're in a larger
package WITH a license, and no reason to believe that they had a different
one, the license info seems to check out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.