[Bug 529198] Review Request: pynac - manipulation of symbolic expressions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529198

--- Comment #9 from David A. Wheeler <dwheeler at dwheeler.com> 2010-01-28 18:32:08 EST ---
My theory is, if it's a MUST in the guidelines, then it's required... even if
it's automated.

I checked; all of the comments above have now been addressed.  Thanks!!

I did a few checks to make sure the new version didn't add surprises.

I rebuilt the new version.  It whines with a lot of warnings, but it builds
fine.

rpmlint output for this version is the same as before (see comment 5), so
that's fine:
rpmlint pynac.spec ../RPMS/x86_64/pynac-* ../SRPMS/pynac-0.1.11-1.fc12.src.rpm 
pynac-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 1 warnings.

I also did a mock build to see if new dependencies were created:
  mock --rebuild ../SRPMS/pynac-0.1.11-1.fc12.src.rpm 
and it went fine.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.