[Bug 559856] Review Request: libbsd - Library providing BSD-compatible functions for portability

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=559856

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi

--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-01-29 03:32:03 EST ---
A few notes:

- Here you don't need to do anything that requires knowing the exact SOversion,
so you can safely drop the SOlib definitions. Just hard-code the version to
0.2.0 and use wildcards %{name}.so.* in %files.

- Does the library *really* have hard-coded paths in the source code? If not,
then you can drop libdir=%{_libdir} usrlibdir=%{_libdir} exec_prefix=/usr" from
the make command.

- Use %{_prefix} instead of /usr.

- If you remove nlist.h, then you should require the package that provides it.
Are the files really compatible?

- You should own the directory %{_includedir}/bsd/.

- The devel package should Requires: pkgconfig, if you are going to build for
EPEL, modern Fedoras pick up the requirement automatically.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.