[Bug 558824] Review Request: rubygem-xmpp4r - XMPP4R is an XMPP/Jabber library for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=558824

--- Comment #4 from Mark Chappell <m.d.chappell at bath.ac.uk> 2010-01-29 07:32:18 EST ---
* Fixed the src.rpm file permissions
* Replaced tabs with spaces
* Removed the redundant "XMPP4R is an" from the Summary
* removed the %doc lines in the -doc package
* data, data/doc and data/doc/xmpp4r now have owners
* Tests enabled
* Removed unused macro
* Replaced the "%define"s with "%global"

New Spec in the same location:
http://people.bath.ac.uk/ee0mdc/rpm/rubygem-xmpp4r/rubygem-xmpp4r.spec

New SRPM:
http://people.bath.ac.uk/ee0mdc/rpm/rubygem-xmpp4r/rubygem-xmpp4r-0.5-2.fc12.src.rpm

Relevant RPM Lint output
ee0mdc:vampire:~ $ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm | grep
-v yaml
rubygem-xmpp4r.src: W: patch-not-applied Patch0: rubygem-xmpp4r-examples.patch
rubygem-xmpp4r.src: W: patch-not-applied Patch1: rubygem-xmpp4r-tests.patch
rubygem-xmpp4r-doc.noarch: W: no-documentation

The patches have been applied, and the "no-documentation" is the doc package.


Thank you very much for your time so far Mamoru

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.