[Bug 559856] Review Request: libbsd - Library providing BSD-compatible functions for portability

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=559856

--- Comment #5 from Ralf Corsepius <rc040203 at freenet.de> 2010-01-29 23:24:57 EST ---
(In reply to comment #4)
> > Actually, I feel this package is not really close to what it intends to be.
> 
> What do you mean?

I feel this package is immature and suffers from an inconsistent design.

E.g. it provides
a) /usr/include/vis.h
It is adding a bsd-header to glibc.

b) /usr/include/bsd/*.h
These files only are usable if being explicitly included,
e.g. #include <bsd/string.h>

=> inconsistent design.

Also, it's not clear to me, if -I/usr/include/bsd ... (overriding system
headers with bsd headers) is supposed to work. 
I guess, no, because a) from the list above doesn't match with this kind of
usage. AFAIS, the contents of the files below bsd/ seem to be inconsistent wrt.
this kind of usage.

> > Not really. Simply install this library's headers into a subdirectory of
> > %{_includedir}

> Many of them were already in %{_includedir}/bsd

I sense a misunderstanding.

I recommend you to install this packages headers into a subdirectory of
%{_includedir}, e.g. /usr/include/libbsd, such that you would end up with
/usr/include/libbsd/vis.h
...
/usr/include/libbsd/bsd/getopts.h
...
/usr/include/libbsd/bsd/sys/cdefs.h
...

This gets this library's headers out of gcc's default include search path and
circumvents potential conflicts with glibc. Users would explictily have to use
-I/usr/include/libbsd to get libbsd headers pulled in.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.