[Bug 550067] Review Request: perl-Template-Tiny - Template Toolkit reimplemented in as little code as possible

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550067

--- Comment #4 from Emmanuel Seyman <emmanuel.seyman at club-internet.fr> 2010-01-30 03:00:25 EST ---

Haven't finished review yet but I've stumbled on a couple of problems.

- The version packaged is 0.09 but 0.10 is the latest available.
Please update the package or give a compelling reason for staying on 0.09.

- rpmlint gives the following output on the .src.rpm :

perl-Template-Tiny.src: E: description-line-too-long Template::Tiny is a
reimplementation of a partial subset of the Template Toolkit,
perl-Template-Tiny.src: E: description-line-too-long in as few lines of code as
possible. It is intended for use in light-usage, low-memory,
perl-Template-Tiny.src: E: description-line-too-long or low-cpu templating
situations, where you may need to upgrade to the full feature set
perl-Template-Tiny.src: E: description-line-too-long in the future, or if you
want the familiarity of TT-style templates. It is intended to
perl-Template-Tiny.src: E: description-line-too-long have fully-compatible
template and stash usage, with a limited by similar Perl API.
perl-Template-Tiny.src: E: description-line-too-long Unlike Template Toolkit,
Template::Tiny will process templates without a compile phase
perl-Template-Tiny.src: E: description-line-too-long (but despite this is still
quicker, owing to heavy use of the Perl regular expression engine.

Please fix the description.

The spec file (and META.yaml) say this module requires Test::More but I'm not
saying this in the code. Everything else looks fine but I'ld rather hold off
review until the above two items are fixed.

FAIL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.