[Bug 557957] Review Request: perl-Text-vCard - CPAN module for handling vCard files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557957

--- Comment #7 from Philip Prindeville <philipp at redfish-solutions.com> 2010-01-30 14:42:46 EST ---
(In reply to comment #5)
> (In reply to comment #3)
> > 
> > Spec URL: http://philipp.fedorapeople.org/perl-Text-vCard.spec
> 
> FYI, This gives me a 404 error.

Fixed.


> === KEY ===
>  - = N/A
>  x = Check
>  ! = Problem
>  ? = Not evaluated
> 
> === REQUIRED ITEMS ===
>
>      Tested on:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1953530

New link:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1953961


>  [!] Rpmlint output:
> [manu at orient perl-Text-vCard]$ rpmlint perl-Text-vCard*fc13*
> perl-Text-vCard.spec 
> perl-Text-vCard.noarch: W: incoherent-version-in-changelog 2.07 ['2.07-1.fc13',
> '2.07-1']
> 2 packages and 1 specfiles checked; 0 errors, 1 warnings.
> 
> Philip, please use version-release in your changelogs. Version alone is
> not sufficient to tell one rpm from another. Also, please avoid changelog
> entries like "Version bump to latest.". These don't age well.

Fixed.

>  [x] All build dependencies are listed in BuildRequires, except for any that
> are listed in the exceptions section of Packaging Guidelines.
> 
> Nitpick : The version numbers on the BuildRequires are superfluous and
> should probably be removed.

I was told during a pre-review on #fedora-devel (by someone very active there)
to use cpanspec and that in general, the output of cpanspec was golden and
could be left as-is 99% of the time (especially for trivial packages like this
one).

This is what I've tried to do.

Perhaps if cpanspec is generating superfluous output, that should be addressed
instead.

> === SUGGESTED ITEMS ===
>  [!] Package functions as described.
> 
> Description doesn't say what the package actually does. Please fix it!

Changed to:

Text::vCard - a package to edit and create vCards (RFC 2426)

(note the text is pretty much taken as is from the synopsis of the package's
perldoc... I will ask the upstream author to make this a little more
comprehensive in subsequent releases.)

>  [x] %check is present and the tests pass
> 
> Your Requires are also superfluous, being already picked up by rpmlib.
> Please remove them.

Again, these were generated by cpanspec and left as is (per guidance received).

If the output of cpanspec is known to be broken, why hasn't that been
addressed?

> FAIL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.