[Bug 509160] Review Request: mine_detector – a mine-finding game

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 30 21:33:05 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509160

--- Comment #20 from Björn Persson <bjorn at xn--rombobjrn-67a.se> 2010-01-30 16:32:56 EST ---
(In reply to comment #18)
Thanks for the information Toshio.

(In reply to comment #17)
> Sadly, the new SRPM creates a new rpmlint error:
>  rpmlint mine_detector.spec ../RPMS/x86_64/mine_detector-6.0-3.fc12.x86_64.rpm
> ../SRPMS/mine_detector-6.0-3.fc12.src.rpm 
> mine_detector.x86_64: W: file-not-utf8
> /usr/share/doc/mine_detector-6.0/license_clarification.mbox

Strictly speaking it's a warning, not an error.

> I suggest changing .mbox to .txt, and invoking "iconv" during %prep or %build
> to convert the file to UTF-8.

I am STRONGLY against shipping the emails with incorrect MIME headers. If
someone does load them in an MUA they shall be displayed correctly!

I used the mbox format because I got the impression that it's important to keep
the emails authentic. If UTF-8 is more important than authenticity, then there
are three ways I could make RPMlint happy:

1: I could apply Quoted-Printable to the bodies of the first and the third
email and change the Content-Transfer-Encoding headers accordingly.
Quoted-Printable would then be used consistently throughout the file, and
RPMlint would be satisfied as the whole file would be pure ASCII. When viewed
with a pager or text editor the file would look equally bad to all users
regardless of their locale, but all three emails would be displayed correctly
in a good MUA.

2: I could convert the bodies of the first and the third email to UTF-8 and
change the Content-Type headers accordingly, so that at least two of the
occurrences of my name would be fully readable to those users who use UTF-8 in
their locales. (Note that which encoding a pager or text editor will assume
depends on the user's locale setting. Not everyone is using UTF-8 in their
locale.) I'd have to leave the middle email Quoted-Printable-encoded, because
any changes would invalidate the PGP signature. The address headers would also
have to remain Quoted-Printable-encoded. All three emails would still be
displayed correctly in a good MUA.

3: I could abandon the mbox format and merge the emails and the explanatory
text that I put in README.Fedora into a single text file. The file would not
contain authentic emails but rather plaintext representations of the emails. I
would then remove all transfer encoding from both bodies and address headers
and convert everything to UTF-8. I would also remove the MIME headers and the
PGP signature as they would no longer apply. This would make all three emails
as easy to read as possible to users viewing them with a pager or text editor
in a UTF-8 locale, but it would no longer be possible to view them with an MUA.

Another approach could be to declare that this is one of those cases where
RPMlint is wrong.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list