[Bug 557957] Review Request: perl-Text-vCard - CPAN module for handling vCard files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557957

--- Comment #9 from Emmanuel Seyman <emmanuel.seyman at club-internet.fr> 2010-01-30 17:16:17 EST ---
(In reply to comment #7)
> (In reply to comment #5)
>
> > FYI, This gives me a 404 error.
> 
> Fixed.

Thanks!

> > Nitpick : The version numbers on the BuildRequires are superfluous and
> > should probably be removed.
> 
> I was told during a pre-review on #fedora-devel (by someone very active there)
> to use cpanspec and that in general, the output of cpanspec was golden and
> could be left as-is 99% of the time (especially for trivial packages like this
> one).
> 
> This is what I've tried to do.
> 
> Perhaps if cpanspec is generating superfluous output, that should be addressed
> instead.

The decision to version BuidRequires (and Requires) is somewhat
context-specific and the decision to keep the version is something that
cpanspec cannot take.

See https://fedoraproject.org/wiki/Packaging:Guidelines#Requires for details.

> Changed to:
>
> Text::vCard - a package to edit and create vCards (RFC 2426)

Descriptions should be in the form of complete sentences and should expand on
the summary, not repeat it.

https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description:
"The summary should be a short and concise description of the package. The
description expands upon this."

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.