[Bug 551724] Review Request: php-phpmd-PHP-PMD - PHPMD - PHP Mess Detector

bugzilla at redhat.com bugzilla at redhat.com
Sun Jan 31 07:03:01 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551724

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #8 from Remi Collet <fedora at famillecollet.com> 2010-01-31 02:02:58 EST ---
REVIEW:

+ rpmlint is ok
php-phpmd-PHP-PMD.noarch: I: checking
php-phpmd-PHP-PMD.src: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines
+ License ok : BSD
+ License is upstream 
+ spec in english and legible
+ provided license file 
+ sources match the upstream sources
9c76d49df7137b52332267b76bb11f64  PHP_PMD-0.2.2.tgz
+ Source URL ok
+ build  on F12.x86_64
+ BuildRequires (php-pear >= 1:1.6.0, php-channel(pear.phpmd.org)) ok
+ no locale
+ no .so
+ own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
+ use macros consistently
+ contain code
+ small documentation not required to run
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ test suite ok (can't be run during build)
+ scriptlets ok
+ Final Requires ok
/usr/bin/pear  
/usr/bin/php  
php-channel(pear.phpmd.org)  
php-common >= 5.2.0
php-pear(pear.pdepend.org/PHP_Depend) >= 0.9.7
php-xml  
+ Final Provides ok
php-pear(pear.phpmd.org/PHP_PMD) = 0.2.2
php-phpmd-PHP-PMD = 0.2.2-1.fc8
+ Build in koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=1954558
+ run ok

in %file, should use %{pear_datadir}/PHP_PMD instead of
%{pear_phpdir}/data/PHP_PMD


===== APPROVED =====

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list