[Bug 556433] Review Request: rubygem-eventmachine - Ruby/EventMachine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556433

--- Comment #2 from Ruben Kerkhof <ruben at rubenkerkhof.com> 2010-01-31 07:54:35 EST ---
Hi Mamoru, thanks for the review!

> - Use "BR: rubygem(rake)" instead of "BR: rubygem-rake" ref:
>  https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

Fixed. This seems something that should be added to the ruby guidelines as well
:-)

> - Don't strip binary and create debuginfo rpm correctly.
Oops, fixed.

> - Test fails like:
>  http://koji.fedoraproject.org/koji/taskinfo?taskID=1952077
>  - 10 tests errors seem to be due to net connection
>  -  1 error seems to occur occasionally

The 10 tests try to open a connection to 127.0.0.1. Apparently this is not
allowed by koji.

The failure is a timing test which didn't complete in time. This probably
depends on how fast the build host is.

For now I've added a || : to the %check section.

> - Please mark document files as %doc appropriately
>  - At least README file, example/ docs/ directories should be 
>    marked as %doc
>  - Also I guess tasks/ tests/ web/ directories and Rakefile can be marked
>    as %doc
>  - it may be preferable to split example/ docs/ tasks/ tests/ web/
>    directories and Rakefile into -doc subpackage (I would do so).

Ok, I've made a -doc subpackage.

> - %geminstdir/%gemname.gemspec is not needed. gemspec file is
>  installed under specifications directory.

Fixed.

> - Use %geminstdir macro in %files as this is defined in the spec file.

Fixed.

> - License tag should be "GPLv2 or Ruby"

Fixed.

New version here:
Spec URL: http://ruben.fedorapeople.org/rubygem-eventmachine.spec
SRPM URL:
http://ruben.fedorapeople.org/rubygem-eventmachine-0.12.10-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.