[Bug 504476] Review Request: rubygem-newgem - Bundle Ruby libraries into a RubyGem

bugzilla at redhat.com bugzilla at redhat.com
Sun Jan 31 13:49:52 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504476

--- Comment #14 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-31 08:49:44 EST ---
My comments (to mkent's 1.5.2-2)

* License
-------------------------------------------------------------
Overall: MIT

LGPLv2+:
./newgem_theme_generators/long_box_theme/templates/website/javascripts/rounded_corners_lite.inc.js
./newgem_theme_generators/plain_theme/templates/website/javascripts/rounded_corners_lite.inc.js
./website/javascripts/rounded_corners_lite.inc.js 
-------------------------------------------------------------
  - The license tag should be "MIT and LGPLv2+".

* Requires
  - Currently I cannot figure out why "R: rubygem(activesupport)" is needed.
    Also, I cannot figure out why "['activesupport','>= 2.0.2']," is in
Rakefile.

  - Would you check if the following dependencies are optional or
    rather mandatory?
-------------------------------------------------------------
./lib/newgem/rubyforge-ext.rb:  require 'rubyforge'
-------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list