[Bug 556433] Review Request: rubygem-eventmachine - Ruby/EventMachine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556433

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review+

--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-31 09:14:54 EST ---
One issue and one comment
* ruby(abi) dependency
  - "Requires: ruby(abi) = 1.8" is missing. Please add this.

! %doc in -doc subpackage
  - Not a blocker, however I think %doc attribute in -doc subpackage
    is redundant because rpm name already shows that the rpm (-doc
    subpackage) is for documentation.

Fix these before importing.
------------------------------------------------------------------
    This package (rubygem-eventmachine) is APPROVED by mtasaka
------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.