[Bug 555187] Review Request: bagel - An online french word game

bugzilla at redhat.com bugzilla at redhat.com
Sun Jan 31 16:25:44 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555187

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #10 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-31 11:25:37 EST ---
Some notes:

* Obsoletes
  - Since baggle{,-server} packages are not yet imported into
    Fedora, these Obsoletes are not needed.

* baggle -> bagel
  - Fix SOURCE2 (bagel.desktop)

* About SOURCE2/4
  - I guess using "exec" shell builtin is better like:
----------------------------------------------------------------
#!/bin/sh

exec java -jar /usr/share/java/bagel-server.jar "$@"
----------------------------------------------------------------

* Requires
  - I guess ">= 1:1.6.0" on java dependency should added
    also in -server subpackage.

* Undefined macro
----------------------------------------------------------------
mkdir -p %{buildroot}%{icondir}
----------------------------------------------------------------
  - %icondir macro is defined nowhere, and it seems to be
    used nowhere anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list