[Bug 560322] Review Request: urg - Library to access Hokuyo URG laser range finders

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560322

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mschwendt at gmail.com
         AssignedTo|nobody at fedoraproject.org    |mschwendt at gmail.com

--- Comment #1 from Michael Schwendt <mschwendt at gmail.com> 2010-01-31 12:04:08 EST ---
* Hardcoded /usr/lib in -config scripts in x86_64 package.

* /usr/include/urg/findFiles.h depends on boost-devel, but this header is
optional (currently) and hence the dependency on boost-devel is optional. So,
this acceptable.

* Only the README mentions the LGPL licensing with a single word. Less than
ideal (as preferably, the source files also refer to the licensing), but
acceptable.

$ rpmlint urg-*.x86_64.rpm
urg.x86_64: W: spelling-error Summary(en_US) Hokuyo -> Hokum, Hokusai, Hokey
urg.x86_64: W: name-repeated-in-summary C URG
urg.x86_64: W: spelling-error %description -l en_US Hokuyo -> Hokum, Hokusai,
Hokey
urg-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

* src.rpm crashes rpmlint from updates-testing ;)

* "spectool -g urg-0.8.7-1.fc12.src/urg.spec" only retrieves a HTML page, not
the tarball.

* Please point out the compiler warnings to upstream. Especially the format
string warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.