[Bug 547226] Review Request: python-pgu - pygame addon for making GUIs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=547226

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp
            Summary|Review Request: pgu -       |Review Request: python-pgu
                   |pygame addon for making     |- pygame addon for making
                   |GUIs                        |GUIs

--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-31 12:47:58 EST ---
Some notes:

* License
  - License tag for this package should be "LGPLv2+".

* Macros
  - Use macros correctly. /usr/share should be %{_datadir}
    https://fedoraproject.org/wiki/Packaging/RPMMacros

* Bundled fonts
  - Fedora forbids including font files bundled in non-font
    software tarballs into binary rpms. If such fonts are
    needed for the software, you have to replace the bundled
    font files with font files provided by font-related binary
    rpms 
    (i.e. replace the actual font file with symlink to
          the font file provided by font related rpms)
    - For this package, Vera.ttf is provided by bitstream-vera-sans-fonts,
      for example and you should use this system-widely provided
      font file.

* Documents
  - Usually files like "INSTALL.txt" are for people trying to
    build the software by themselved and not needed for people
    using rpm
  - Also "build.py" under %docdir/%name-%version seems unneeded.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.