[Bug 560179] accountsdialog - An application to view and modify user accounts information

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560179

--- Comment #2 from Matthias Clasen <mclasen at redhat.com> 2010-01-31 13:42:49 EST ---
> - The package doesn't build against the Polkit in F12, so please add the
> minimim required version to the polkit-devel BuildRequires.

Hmm, I just tried, and it build fine in mock here. What failure are you seeing
?

> - You are not using desktop-file-install or desktop-file-validate for
> accountsdialog.desktop

I'll add that.

> - The Exec= line in the desktop file should not have an absolute path.

Not sure there is any rule about this, and I don't think it makes a difference
either way. But I've remove the path in git, will be in the next release.

> - Add INSTALL='install -p' to make install to preserve the timestamps of the
> data files (pixmaps etc).

I don't think it makes any difference whatsoever, but I'll add it to make you
happy.


> - The source code is a mixture of GPLv2+ and GPLv3, src/locarchive.h is
> LGPLv2+. Can this be cleaned up?

No. These are files that are copied from elsewhere.

> - There are files from fprint and GDM included in the source, which violates
> the "No duplication of system libraries" policy. I assume this code will be
> moved into it's proper upstream packages once it's mature and you will build
> against these packages then, so for now this is not a problem.

Not sure where you are going with this, but copying and adapting sources from
elsewhere is quite normal, and the system library rule doesn't even come into
play since we are not building any libraries here at all.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.