[Bug 539388] Review Request: xmlrpc-epi - An implementation of the XML-RPC protocol in C.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539388

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|needinfo?(mtasaka at ioa.s.u-t |
                   |okyo.ac.jp)                 |

--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-31 13:59:19 EST ---
(In reply to comment #4)
> Mamoru Tasaka can you please check my review please?    
Almost okay, thank you.

Some comments from me:
* %setup directory / debuginfo rpm creation
-------------------------------------------------------------
    25  %prep
    26  %setup -q -n xmlrpc
-------------------------------------------------------------
  - As shown here, when the source tarball is to be expanded,
    the directory named "xmlrpc" is created and source codes
    are expanded there.
    This means that when -debuginfo rpm is created, the included
    source codes are installed through debuginfo rpm under
    /usr/src/debug/xmlrpc .

    However Fedora already has "xmlrpc" package and
    xmlrpc-debuginfo uses "/usr/src/debug/xmlrpc-2.0.1/", so
    using /usr/src/debug/xmlrpc is confusing.

    Please expand source tarball under %_builddir/%name-%version
    like below:
-------------------------------------------------------------
@@ -1,12 +1,12 @@
 Name:      xmlrpc-epi
 Version:   0.54.1
-Release:   1%{?dist}
+Release:   2%{?dist}
 Summary:   An implementation of the XML-RPC protocol in C
 Group:     System Environment/Libraries
 License:   MIT
 URL:       http://xmlrpc-epi.sourceforge.net/
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-Source:    http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
+Source0:    http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
 BuildRequires: expat-devel
 BuildRequires: libtool

@@ -23,15 +23,19 @@
 developing applications that use xmlrpc-epi.

 %prep
-%setup -q -n xmlrpc
+%setup -q -c -T -a 0

 %build
+cd xmlrpc
+cp -p [A-Z]* ..
+
 %configure --disable-static --includedir=%{_includedir}/xmlrpc-epi
 make %{?_smp_mflags}

 %install
 rm -rf %{buildroot}
-make install DESTDIR=%{buildroot}
+cd xmlrpc
+make install DESTDIR=%{buildroot} INSTALL="%{__install} -p"
-------------------------------------------------------------
    ! Note
      - Source is changed to Source"0" to use "-a 0" usage in
        %setup -q.

* Timestamps
  - As shown above, please consider to use
    'INSTALL="%{__install} -p"' option to "make install" to
    keep timestamps on installed files as much as possible.
    This method usually works for Makefiles generated by recent
    Makefiles.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.