[Bug 521716] Review Request: python-zfec - A fast erasure codec with python bindings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521716

--- Comment #4 from Thomas Spura <tomspur at fedoraproject.org> 2010-01-31 16:34:27 EST ---
- sources matches upstream: 542957786c0b5de3ff76094349d0cf0d


Only SHOULDS left:

(In reply to comment #3)
> > - Query upstream to add license headers.
> Why, the license is included

I remember, it's negative to not have headers, but can't find it in the
guidelines. Only in COPYING.GPL it's just suggested in 'How to Apply These
Terms to Your New Programs' too. Because you seem to be in contact with
upstream, you could ask them to add the headers.
But this is a should anyway... ;)


- Deleting the tests would be good:
  Then there would be installed just what is needed.
  Here it doesn't matter much, because the tests are small...


##############################################################


I'd approve this now, but I want to wait for the dependencies.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.