[Bug 608319] Review Request: memaker - An avatar creator

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 1 10:41:35 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608319

Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name

--- Comment #2 from Till Maas <opensource at till.name> 2010-07-01 06:41:34 EDT ---
(In reply to comment #1)

> There are some issues already:
> 
> It's a python module, but doesn't use any setuptools etc. I've manually
> installed *all* files. Therefore, there are no egg files at the moment (I
> couldn't figure out how to generate them manually). 

Imho the best solution is to ask upstream to use a setup.py file or write one
yourself and submit it upstream.

Btw. it looks to me that %{python_sitelib}/MeMaker/ is not owned, so a %dir
%{python_sitelib}/MeMaker/ needs to be added to %files.

And the patch should be submitted upstream if appropriate and a comment added
that explains it's upstream status or why it is not appropriate for upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list