[Bug 609638] Review Request: kpassgen - Random password creater

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609638

Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kalev at smartlink.ee

--- Comment #1 from Kalev Lember <kalev at smartlink.ee> 2010-07-02 13:03:42 EDT ---
It appears that you have modified the spec file after initial submission. If
you do that, please bump the Release, update %changelog and post new links to
spec and srpm in this ticket.

> Group: Utilities
Use one of groups from /usr/share/doc/rpm-*/GROUPS file instead; Utilities
isn't a standard rpm group.

> License: GNU
Refer to http://fedoraproject.org/wiki/Licensing page to figure out what to put
in the License tag.

> %description
> A random password creator

Perhaps you can be a bit more verbose? There's a nice description at
http://kde-apps.org/content/show.php/KPassGen?content=108673 , use that.

You need to use either desktop-file-install or desktop-file-validate as per
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

%doc is currently empty. KPassgen has COPYING file in the tarball and you need
to include that in the rpm too:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.