[Bug 607584] Review Request: wordgroupz - A vocabulary building application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607584

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-07-02 14:00:06 EDT ---
Some notes:

* BuildRoot
  - On Fedora "BuildRoot" tag is no longer used and can be removed
    (even if rpmlint may complain if you remove it)
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
    - If you want to import this package also into EPEL, BuildRoot tag
      is still needed.

* License tag
  - As far as I checked the whole codes, the license tag should be
    "GPLv2+".

* BuildRequires for python
  - Please use "BuildRequires: python2" instead of "BR: python", c.f.
    https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

* BuildRequires v.s. Requires
  - Please check if the dependencies you wrote in the spec file is
    for BuildRequires or for Requires.
    - BuildRequires are the packages required when rebuilding srpm,
      while Requires are the packages required when installing the rebuilt
      binary rpm (i.e. when using the software).
      For example, actually your srpm builds only with "BR: python2":
      http://koji.fedoraproject.org/koji/taskinfo?taskID=2289162

      However without pygtk2 this package won't work (i.e. wordgroupz won't
      run), this means pygtk2 should be in "Requires", not in "BuildRequires".

  ! On F-12+, sqlite3 module is already in "python" package, so "Requires:
python-sqlite"
    is redundant. Also gtk2 package is always required by pygtk2, so "Requires:
gtk2"
    is unneeded.

* CFLAGS
  - This is noarch package, so 'env CFLAGS="$RPM_OPT_FLAGS"
    is not needed.

* Installing desktop files
  - When a package contains desktop file, "desktop-file-{install,validate}"
must
    be used and "BR: desktop-file-utils" must be included:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

* Desktop file
  - "Application" category in desktop file is deprecated and should
    be removed.

* Directory ownership issue
  - Please make it sure that all directories which are newly created when
installing
    this package are correctly owned by this package:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
    https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Common_Mistakes
    - The directory %{_datadir}/wordgroupz/ itself is not owned by any
packages.

* Permission
  - rpmlint complains:
----------------------------------------------------------------------------------
wordgroupz.noarch: E: script-without-shebang
/usr/share/wordgroupz/wordgroupz.glade
wordgroupz.noarch: E: script-without-shebang
/usr/share/applications/wordgroupz.desktop
----------------------------------------------------------------------------------
    This is because these files have executable permissin (0755) but it must
not.
    Also .png file has 0755 permission, which should be 0644. Please fix the
permission.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.