[Bug 602279] Review Request: LibRaw - Library for reading RAW files obtained from digital photo cameras

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602279

--- Comment #13 from Chen Lei <supercyper1 at gmail.com> 2010-07-03 13:05:50 EDT ---
1.For rpmbuild log:
g++ -DLIBRAW_NOTHREADS -O4 -I. -w -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o
bin/4channels samples/4channels.cpp -L./lib -lraw  -lm  


Please remove -O4 and -w from CFLAGS.

2. rpmlint LibRaw-0.9.1-5.fc14.src.rpm 
LibRaw.src: W: spelling-error %description -l en_US dcraw -> draw, craw, d craw
LibRaw.src: W: no-cleaning-of-buildroot %clean
LibRaw.src: W: no-%clean-section
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

%clean-section is still needed for F12 and below.

3. Patch name:

It'll be better to add %{name}-%{version} into patch name.

e.g. 
Patch0: LibRaw-0.9.1-configure.patch

Patch1: LibRaw-0.9.1-configure-optflags.patch


4. Group: Amusements/Graphics -> Development/Libraries


5.%setup -q -n %{name}-%{version} can be shorted to %setup -q

6. License: LGPLv2+ with exceptions
Please explain why you use this license for LibRaw.
>From website, I see the license is LGPLv2+ or CDDL or LibRaw

Please try to contact fedora-legal to add LibRaw license for fedora

See http://fedoraproject.org/wiki/Licensing#Software_License_List

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.