[Bug 605423] Review Request: python-dulwich - A python implementation of the Git file formats and protocols

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605423

--- Comment #5 from Fabian Affolter <fabian at bernewireless.net> 2010-07-03 18:37:10 EDT ---
(In reply to comment #3)
> Here is the full review for the latest package:
> 
> * rpmlint: TODO (minor)
> In general the rpmlint output is OK, probably it would be better to remove the
> +x permission from test.py just to keep rpmlint silent. It should be no problem
> just to use "python test.py" whenever someone tries out the example from the
> tutorial.

Exec permission removed

> * Compilation: TODO
> - package does not build in koji
> - you have to add python-nose as BR for the tests

Added, package builds in koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=2292934

> * Requires: TODO
> - the used command for filtering out unwanted dependencies will probably remove
> too many provides/requires ("grep -v %{srcname}")
> - something like "grep -v -E '(_objects.so|_pack.so)' should be better

Changed

> * functional test: ??
> - dulwich itself works fine

Yepp, it's one of the only working features.

> - dul-daemon works for some local git clones, but does not for others (I could
> not clone from them.)
> - dul-web did not work for me

dul-* seams partially to work but they are not really useful because they lacks
to almost every functionality. 

> Since the client functionality seems to work quite ok, I think these bugs
> should not block the review. However it would be good if you could report them
> upstream - with luck upstream can provide some bug fixes short-term.

Thanks for the review.

Here are the updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-dulwich.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-dulwich-0.6.0-3.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.