[Bug 611165] Review Request: perl-Devel-PartialDump - Partial dumping of data structures, optimized for argument printing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611165

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-07-04 09:12:54 EDT ---
! Two comments

rpmlint may complain, however
- BuildRoot is no longer needed (on Fedora: if you want to import this
  package also into EPEL, BuildRoot tag is needed there)
- On Fedora 13+, writing %clean section explicitly is no longer needed
  (on F-12 and EPEL, writing %clean explicitly is still needed) 

+ spec file generally okay
+ tarball matches the upstream
+ license matches
+ builds on koji (at least for dist-rawhide, dist-f13-updates-candidate)
+ can be installed (with yum --nogpgcheck localinstall)
+ needed requires (especially module compat one) explicitly written
+ check succeeds
+ %files entry okay
+ seems to work (use Devel::PartialDump; seems to succeed)

+ not still in Fedora yet, duplicate review request not found
  (on google)

approving.

-------------------------------------------------------------------
    This package (perl-Devel-PartialDump) is APPROVED by mtasaka
-------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.