[Bug 581220] Review Request: qtsingleapplication - Qt library to start applications only once per user

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581220

Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #18 from Kalev Lember <kalev at smartlink.ee> 2010-07-04 18:29:43 EDT ---
Fedora review qtsingleapplication-2.6.1-1.fc13.src.rpm 2010-07-05

+ OK
! needs attention

rpmlint output:
qtsingleapplication.src:60: W: configure-without-libdir-spec
qtsingleapplication.i686: W: unused-direct-shlib-dependency
/usr/lib/libQtSolutions_SingleApplication-2.6.so.1.0.0 /lib/libm.so.6
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package follows the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains license files (LGPL_EXCEPTION.txt, LICENSE.GPL3, and
LICENSE.LGPL)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  902795eb13ecedbdc112f00d7ec22949  qtsingleapplication-2.6_1-opensource.tar.gz
  902795eb13ecedbdc112f00d7ec22949 
Download/qtsingleapplication-2.6_1-opensource.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
+ ldconfig is properly called in %post and %postun
+ Package does not bundle copies of system libraries
n/a Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ Consistent use of macros
+ The package must contain code, or permissable content.
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc don't affect the package
+ Header files are in -devel
n/a Static libraries should be in -static
+ Library files that end in .so are in -devel package
+ -devel requires the fully versioned base
+ Package doesn't contain any libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.