[Bug 611648] Review Request: mtdev - Multitouch Protocol Translation Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611648

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review?

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-06 08:02:22 EDT ---
Review:
- license ok

- Why do you BR git? Because you use it to make the sources?

- name: How about "libmtdev" like e.g. libacpi or libmpd?

- %doc: Please add README and CREDITS

- Please use: 'make install DESTDIR=%{buildroot} INSTALL="install -p"'

- You mix $RPM_BUILD_ROOT and %{buildroot}

- libfoo.so needs to be in the -devel package:
  from rpmlint: mtdev.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libmtdev.so

- mtdev.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmtdev.so.1.0.0
  mtdev.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmtdev.so.1.0.0
  see: https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

- mtdev-devel.x86_64: W: summary-not-capitalized C multitouch protocol
translation library development package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.