[Bug 226407] Merge Review: sendmail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #56 from Paul Howarth <paul at city-fan.org> 2010-07-06 12:24:51 EDT ---
OK, here's another pass:

rpmlint
=======
sendmail.src:61: W: unversioned-explicit-provides MTA
sendmail.src:61: W: unversioned-explicit-provides smtpdaemon
sendmail.src:61: W: unversioned-explicit-provides server(smtp)
=> normal for virtual provides, ignorable

sendmail.src:270: E: hardcoded-library-path in %{buildroot}/usr/lib
sendmail.src:309: E: hardcoded-library-path in
%{buildroot}/usr/lib/sendmail.sendmail
sendmail.src:408: E: hardcoded-library-path in %{buildroot}/usr/lib/sendmail
sendmail.src:445: E: hardcoded-library-path in /usr/lib/sendmail.sendmail
sendmail.src:501: E: hardcoded-library-path in /usr/lib/sendmail.sendmail
sendmail.src:518: E: hardcoded-library-path in /usr/lib/sendmail
=> legitimate install of /usr/lib/sendmail for backward script compatibility

sendmail.x86_64: W: only-non-binary-in-usr-lib
=> false positive; there is a symlink to a real binary in /usr/sbin

sendmail.x86_64: E: setgid-binary /usr/sbin/sendmail.sendmail smmsp 02755L
sendmail.x86_64: E: non-standard-executable-perm /usr/sbin/sendmail.sendmail
02755L
=> needs to be setgid to function correctly

sendmail.x86_64: E: zero-length /var/log/mail/statistics
=> needs to be present and empty, hence OK

sendmail.x86_64: E: executable-marked-as-config-file /etc/mail/make
=> needs to be executable, needs to be customizable, hence OK

sendmail.x86_64: E: non-standard-dir-perm /var/spool/mqueue 0700L
sendmail.x86_64: E: non-standard-dir-perm /var/spool/clientmqueue 0770L
=> permissions for mail queues are correct

sendmail.x86_64: W: log-files-without-logrotate /var/log/mail
=> statistics file here does not need rotating

sendmail.x86_64: W: no-manual-page-for-binary hoststat
sendmail.x86_64: W: no-manual-page-for-binary rmail.sendmail
sendmail.x86_64: W: no-manual-page-for-binary purgestat
=> see below

sendmail.x86_64: W: dangerous-command-in-%post chown
=> necessary to ensure correct permissions, which sendmail is fussy about

sendmail.x86_64: W: service-default-enabled /etc/rc.d/init.d/sendmail
=> listens only on localhost out of the box, so OK

sendmail.x86_64: E: incoherent-subsys /etc/rc.d/init.d/sendmail sm-client
sendmail.x86_64: E: incoherent-subsys /etc/rc.d/init.d/sendmail sm-client
=> two daemons running, both can't be coherent at the same time

sendmail-cf.noarch: E: non-executable-script
/usr/share/sendmail-cf/sh/makeinfo.sh 0644L /bin/sh
=> the m4 snippet that uses this doesn't need it to be executable, hence OK

sendmail-devel.x86_64: W: spelling-error %description -l en_US addons -> ad
dons, ad-dons, Abaddon
=> could change it to add-ons but it would still fail the spell check

sendmail-doc.noarch: W: spelling-error %description -l en_US troff -> toff, tr
off, tr-off
=> whilst troff is spelt correctly, the assertion that documentation is
   provided in troff format is false; the %description should be re-written
   to reflect the actual contents of the package

sendmail-milter.x86_64: W: no-documentation
=> perhaps move README.libmilter to this package?

Review Checklist
================

- rpmlint mainly OK, as above
- package and spec file naming OK
- package meets guidelines
- license is Sendmail, which is Fedora-approved and matches sources
- upstream license file is packaged OK
- spec file written in English and is legible
- source tarball matches upstream
- package builds fine in mock and koji on all supported architectures
- buildreqs OK
- no translations to worry about
- ldconfig called properly in %post and %postun of milter package; no other
  packages contain shared libraries
- no bundled system libraries
- package not intended to be relocatable
- directory ownership OK
- no duplicate files
- %defattr present and correct, all permissions OK
- macro usage is consistent
- code, not content
- large docs moved to -doc subpackage
- docs don't affect runtime
- header files and libmilter.so symlink properly included in devel subpackage
- no static or libtool libraries packaged
- no pkgconfig files packaged
- devel subpackage has proper dependency on main package
- cf subpackage has proper dependency on main package
- doc subpackage has proper dependency on main package
- milter subpackage correctly does not depend on main package
- not a GUI app, no desktop file needed
- filenames all OK
- package functions OK
- scriptlets are sane
- no file dependencies outside /bin, /sbin, and /usr/sbin
- manpage coverage mostly complete

Issues
======
The hoststat and purgestat commands are described in the main sendmail(8) man
page, so it would be useful to add stub pages for them:

%{_mandir}/man8/hoststat.8 and %{_mandir}/man8/purgestat.8 can just be:
.so man8/sendmail.8

As for rmail, there is a manpage installed but it's not switched in and out
using alternatives. Adding it to the alternatives group should resolve the
rpmlint issue.

%description for the doc subpackage needs rewriting.

/usr/share/sendmail-cf/cf/README is rather useless to end users and doesn't
really need packaging.

The "touch" and initial "chmod" parts of "create db ghosts" in %install are
redundant because the files were created in the immediately preceding part of
the spec, and with the correct permissions.

Some comments in the spec file about the purpose of each patch would be good,
even though there's no upstream bug tracker or development mailing list to
refer to.

Is /usr/sbin/saslauthd really required? I use the auxprop method without
needing saslauthd to run.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.