[Bug 577975] Review Request: kde-plasma-daisy - A versatile application launcher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577975

nucleo <alekcejk at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #14 from nucleo <alekcejk at googlemail.com> 2010-07-06 20:59:58 EDT ---
Package Review
==============

MUST Items:
+ rpmlint output OK
  $ rpmlint kde-plasma-daisy-0.0.4.23-2.fc14.src.rpm
kde-plasma-daisy-0.0.4.23-2.fc14.i686.rpm
kde-plasma-daisy-0.0.4.23-2.fc14.x86_64.rpm
kde-plasma-daisy-debuginfo-0.0.4.23-2.fc14.i686.rpm
kde-plasma-daisy-debuginfo-0.0.4.23-2.fc14.x86_64.rpm                           
  kde-plasma-daisy.src: W: no-buildroot-tag                                     
  5 packages and 0 specfiles checked; 0 errors, 1 warnings.
+ named and versioned according to the Package Naming Guidelines.
  Package name match the upstream project name (Daisy Plasma)
  kde- prefix used by convention for all plasma applets
+ spec file name matches base package name
+ complies with all the legal guidelines:
  + License: GPLv3+ valid, matches actual license
  + No known patent problems
  + No emulator, no firmware, no binary-only or prebuilt components
+ COPYING packaged as %doc
+ source matches upstream:
  MD5: b195b1fdec03c5202ba7247160603e19  plasma-applet-daisy-0.0.4.23.tar.gz
  SHA1: fd4fc608106f03976555777a44e36c84b7397408 
plasma-applet-daisy-0.0.4.23.tar.gz
  SHA256: a3f28e069ec92abf329c86bd71b75ba0fc8475e2554b9e0c94fb2ac993073528 
plasma-applet-daisy-0.0.4.23.tar.gz
+ builds on at least one arch
  F14 Koji scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=2298993
+ no known non-working arches, so no ExcludeArch needed
+ no missing BuildRequires (builds in mock)
+ locales are handled properly by using %find_lang macro
+ ldconfig call not needed (no shared libraries in dynamic linker's default
paths)
+ no duplicated system libraries
+ package not relocatable (no Prefix tag)
+ directory ownership correct (doesn't own directories owned by another
package, owns all package-specific directories)
+ no duplicate files in %files
+ permissions correct, %defattr(-,root,root,-) used correctly, executables have
executable permissions
+ macros used where possible
+ no non-code content
+ no large documentation files, so no -doc package needed
+ no %doc files required at runtime
+ no header files which would need to be in a -devel subpackage
+ no static libraries, so no -static package needed
+ no devel symlinks which would need to be in a -devel subpackage
+ devel packages must require the base package (no -devel package)
+ no .la files
+ no .desktop file needed in /usr/share/applications for plasma applets
+ desktop-file-validate call not needed for .desktop files in
/usr/share/kde4/services
+ all filenames are valid UTF-8
+ other packaging guidelines:
  + complies with the FHS
  + proper changelog, tags, BuildRequires, Summary, Description
  + no macros in Summary and Description
  + no non-UTF-8 characters
  + all relevant documentation included as %doc
  + RPM_OPT_FLAGS are used in %{cmake_kde4} macro
  + debuginfo package is valid (contains stripped symbols from ELF binaries and
source code related to them)
  + no rpaths
  + no configuration files, so %config guideline doesn't apply
  + no init scripts, so init script guideline doesn't apply
  + timestamps are preserved
  + _smp_mflags used
  + not a web application, so web application guideline doesn't apply
  + no conflicts

SHOULD Items:
+ license already included upstream
+ no translations for description and summary provided by upstream
+ package builds in mock (F14 Koji scratch build)
+ successfully tested the package functionality (no segfaults noticed)
+ scriptlets are sane (no scriptlets used)
+ subpackages other than devel should require the base package using a fully
versioned dependency (no subpackages)
+ no .pc files, so "placement of .pc files" is irrelevant
+ no file dependencies
+ no binaries/scripts that needs man pages

Package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.