[Bug 611648] Review Request: mtdev - Multitouch Protocol Translation Library

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 7 09:03:28 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611648

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-07 05:03:26 EDT ---
(In reply to comment #4)
> (In reply to comment #1)
> your rpmlint is more picky than mine it seems :) I didn't get any of these, I
> wonder what I'm doing wrong here.

Hmm, in rawhide is the same rpmlint than in F-13 (from the numbering, it's just
a bit bigger, whyever....)

Remaining rpmlint output:
$ rpmlint ./mtdev-1.0.1-1.20100706.fc13.src.rpm x86_64/mtdev*
mtdev.src: W: spelling-error Summary(en_US) Multitouch -> Multitudinous,
Multitude, Multitask
mtdev.src: W: strange-permission make-git-snapshot.sh 0755L
mtdev.src: W: invalid-url Source0: mtdev-20100706.tar.bz2
mtdev.x86_64: W: spelling-error Summary(en_US) Multitouch -> Multitudinous,
Multitude, Multitask
mtdev-devel.x86_64: W: spelling-error Summary(en_US) multitouch ->
multitudinous, multitude, multitask
mtdev-devel.x86_64: W: summary-not-capitalized C multitouch protocol
translation library development package.
mtdev-devel.x86_64: W: summary-ended-with-dot C multitouch protocol translation
library development package.
mtdev-devel.x86_64: W: spelling-error %description -l en_US Multitouch ->
Multitudinous, Multitude, Multitask
mtdev-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 9 warnings.

So the summary-not-capitalized is still in the -devel package, the rest is
ignorable.

> I also bumped the release down to 1, damn
> copy/paste... Updated files are available on:
> 
> http://people.freedesktop.org/~whot/mtdev-1.0.1-1.20100706.fc14.src.rpm
> http://people.freedesktop.org/~whot/mtdev.spec    

You should bump the release, when doing changes to the spec like you would do
in CVS later on, but now it's approved (just capitalize the summary, when
importing).

____________________________________________________________________________

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list