[Bug 612174] New: Review Request: eurephia - An advanced and flexible OpenVPN user authentication plug-in

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: eurephia - An advanced and flexible OpenVPN user authentication plug-in

https://bugzilla.redhat.com/show_bug.cgi?id=612174

           Summary: Review Request: eurephia - An advanced and flexible
                    OpenVPN user authentication plug-in
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: davids at redhat.com
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---


Spec URL: http://people.redhat.com/dsommers/eurephia/eurephia.spec
SRPM URL:
http://people.redhat.com/dsommers/eurephia/eurephia-1.0.0-1.fc12.src.rpm

Description: 
This plug-in enhances OpenVPN by adding user name and password
authentication in addition. An eurephia user account is a combination of
minimum one OpenVPN SSL certificate and a user name with a password
assigned. It is also possible to setup several eurephia user names to use
a shared OpenVPN certificate.

Remarks:
The following errors and warnings are reported by rpmlint, which I consider
"false positives".  I'll give my arguments for that here.

* eurephia.spec:75: E: use-of-RPM_SOURCE_DIR
One OpenVPN specific file (openvpn-plugin.h) needs to be added extra.  I've
just included that file as a plain text file and does a 'cp' into the source
tree.  I'm using cp  %{_sourcedir}/openvpn-plugin.h to grab the file.  If there
is a better way how to do this, I'm willing to move to that solution.  In the
future I hope this requirement will go away, as I've asked the OpenVPN package
maintainer to include openvpn-plugin.h in the openvpn package.

* eurephia.spec:79: W: configure-without-libdir-spec
The ./configure script is not an autotools script, just a wrapper script around
cmake.  Thus, --libdir is not available.

* eurephia.src: W: spelling-error %description -l en_US iptables -> potables,
portables, birdtables
iptables is a proper name, but not acknowledged by the spell check.

* eurephia-utils.x86_64: W: spelling-error %description -l en_US saltdecode ->
salt decode, salt-decode, saltigrade
This package contains a binary named 'eurephia_saltdecode'.  This binary same
is mentioned in the %description section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.